Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Cleanup detray includes #865

Merged
merged 1 commit into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions benchmarks/common/benchmarks/toy_detector_benchmark.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
#include "traccc/simulation/smearing_writer.hpp"

// Detray include(s).
#include "detray/detectors/bfield.hpp"
#include "detray/io/frontend/detector_reader.hpp"
#include "detray/io/frontend/detector_writer.hpp"
#include "detray/navigation/detail/ray.hpp"
#include "detray/navigation/navigator.hpp"
#include "detray/propagator/propagator.hpp"
#include "detray/propagator/rk_stepper.hpp"
#include "detray/test/utils/detectors/build_toy_detector.hpp"
#include "detray/test/utils/simulation/event_generator/track_generators.hpp"
#include <detray/detectors/bfield.hpp>
#include <detray/io/frontend/detector_reader.hpp>
#include <detray/io/frontend/detector_writer.hpp>
#include <detray/navigation/detail/ray.hpp>
#include <detray/navigation/navigator.hpp>
#include <detray/propagator/propagator.hpp>
#include <detray/propagator/rk_stepper.hpp>
#include <detray/test/utils/detectors/build_toy_detector.hpp>
#include <detray/test/utils/simulation/event_generator/track_generators.hpp>

// VecMem include(s).
#include <vecmem/memory/host_memory_resource.hpp>
Expand Down
12 changes: 6 additions & 6 deletions benchmarks/cpu/toy_detector_cpu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
#include "benchmarks/toy_detector_benchmark.hpp"

// Detray include(s).
#include "detray/core/detector.hpp"
#include "detray/detectors/bfield.hpp"
#include "detray/io/frontend/detector_reader.hpp"
#include "detray/navigation/navigator.hpp"
#include "detray/propagator/propagator.hpp"
#include "detray/propagator/rk_stepper.hpp"
#include <detray/core/detector.hpp>
#include <detray/detectors/bfield.hpp>
#include <detray/io/frontend/detector_reader.hpp>
#include <detray/navigation/navigator.hpp>
#include <detray/propagator/propagator.hpp>
#include <detray/propagator/rk_stepper.hpp>

// VecMem include(s).
#include <vecmem/memory/host_memory_resource.hpp>
Expand Down
12 changes: 6 additions & 6 deletions benchmarks/cuda/toy_detector_cuda.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
#include "benchmarks/toy_detector_benchmark.hpp"

// Detray include(s).
#include "detray/core/detector.hpp"
#include "detray/detectors/bfield.hpp"
#include "detray/io/frontend/detector_reader.hpp"
#include "detray/navigation/navigator.hpp"
#include "detray/propagator/propagator.hpp"
#include "detray/propagator/rk_stepper.hpp"
#include <detray/core/detector.hpp>
#include <detray/detectors/bfield.hpp>
#include <detray/io/frontend/detector_reader.hpp>
#include <detray/navigation/navigator.hpp>
#include <detray/propagator/propagator.hpp>
#include <detray/propagator/rk_stepper.hpp>

// VecMem include(s).
#include <vecmem/memory/cuda/device_memory_resource.hpp>
Expand Down
2 changes: 1 addition & 1 deletion core/include/traccc/definitions/common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "traccc/definitions/primitives.hpp"

// Detray include(s).
#include "detray/definitions/units.hpp"
#include <detray/definitions/units.hpp>

namespace traccc {

Expand Down
58 changes: 3 additions & 55 deletions core/include/traccc/definitions/track_parametrization.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,63 +8,11 @@
#pragma once

// Detray include(s)
// #include "detray/definitions/track_parametrization.hpp"
#include <detray/definitions/track_parametrization.hpp>

namespace traccc {

// @todo: Wait for c++20
// using enum detray::bound_indices;
// using enum detray::free_indices;

/// Components of a bound track parameters vector.
///
/// TODO: consider to use enum class instead of enum
enum bound_indices : unsigned int {
// Local position on the reference surface.
// This is intentionally named different from the position components in
// the other data vectors, to clarify that this is defined on a surface
// while the others are defined in free space.
e_bound_loc0 = 0,
e_bound_loc1 = 1,
// Direction angles
e_bound_phi = 2,
e_bound_theta = 3,
// Global inverse-momentum-like parameter, i.e. q/p or 1/p
// The naming is inconsistent for the case of neutral track parameters where
// the value is interpreted as 1/p not as q/p. This is intentional to avoid
// having multiple aliases for the same element and for lack of an
// acceptable
// common name.
e_bound_qoverp = 4,
e_bound_time = 5,
// Last uninitialized value contains the total number of components
e_bound_size,
};

/// Components of a free track parameters vector.
///
/// To be used to access components by named indices instead of just numbers.
/// This must be a regular `enum` and not a scoped `enum class` to allow
/// implicit conversion to an integer. The enum value are thus visible directly
/// in `namespace Acts` and are prefixed to avoid naming collisions.
enum free_indices : unsigned int {
// Spatial position
// The spatial position components must be stored as one continous block.
e_free_pos0 = 0u,
e_free_pos1 = e_free_pos0 + 1u,
e_free_pos2 = e_free_pos0 + 2u,
// Time
e_free_time = 3u,
// (Unit) direction
// The direction components must be stored as one continous block.
e_free_dir0 = 4u,
e_free_dir1 = e_free_dir0 + 1u,
e_free_dir2 = e_free_dir0 + 2u,
// Global inverse-momentum-like parameter, i.e. q/p or 1/p
// See BoundIndices for further information
e_free_qoverp = 7u,
// Last uninitialized value contains the total number of components
e_free_size,
};
using enum detray::bound_indices;
using enum detray::free_indices;

} // namespace traccc
2 changes: 1 addition & 1 deletion core/include/traccc/edm/measurement.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#include "traccc/utils/subspace.hpp"

// Detray include(s).
#include "detray/geometry/barcode.hpp"
#include <detray/geometry/barcode.hpp>

// System include(s).
#include <limits>
Expand Down
3 changes: 0 additions & 3 deletions core/include/traccc/edm/track_candidate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
#include "traccc/edm/measurement.hpp"
#include "traccc/edm/track_parameters.hpp"

// Detray include(s).
#include "detray/geometry/barcode.hpp"

namespace traccc {

/// Track candidate is the measurement
Expand Down
2 changes: 1 addition & 1 deletion core/include/traccc/edm/track_parameters.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "traccc/edm/container.hpp"

// detray include(s).
#include "detray/tracks/tracks.hpp"
#include <detray/tracks/tracks.hpp>

namespace traccc {

Expand Down
3 changes: 1 addition & 2 deletions core/include/traccc/edm/track_state.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
#include "traccc/edm/track_candidate.hpp"

// detray include(s).
#include "detray/navigation/navigator.hpp"
#include "detray/tracks/bound_track_parameters.hpp"
#include <detray/tracks/bound_track_parameters.hpp>

namespace traccc {

Expand Down
7 changes: 4 additions & 3 deletions core/include/traccc/finding/actors/ckf_aborter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@
#pragma once

// Project include(s)
#include "detray/definitions/detail/qualifiers.hpp"
#include "detray/propagator/base_actor.hpp"
#include "detray/propagator/base_stepper.hpp"
#include "traccc/definitions/primitives.hpp"

// detray include(s)
#include <detray/definitions/detail/qualifiers.hpp>
#include <detray/propagator/base_actor.hpp>

// System include(s)
#include <limits>

Expand Down
3 changes: 1 addition & 2 deletions core/include/traccc/finding/actors/interaction_register.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
#include "traccc/definitions/qualifiers.hpp"

// Detray include(s).
#include "detray/propagator/base_actor.hpp"
#include "detray/propagator/base_stepper.hpp"
#include <detray/propagator/base_actor.hpp>

namespace traccc {

Expand Down
4 changes: 2 additions & 2 deletions core/include/traccc/finding/finding_config.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
#include "traccc/definitions/primitives.hpp"

// detray include(s).
#include "detray/definitions/pdg_particle.hpp"
#include "detray/propagator/propagation_config.hpp"
#include <detray/definitions/pdg_particle.hpp>
#include <detray/propagator/propagation_config.hpp>

namespace traccc {

Expand Down
4 changes: 2 additions & 2 deletions core/include/traccc/fitting/fitting_config.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
#include "traccc/definitions/primitives.hpp"

// detray include(s).
#include "detray/definitions/pdg_particle.hpp"
#include "detray/propagator/propagation_config.hpp"
#include <detray/definitions/pdg_particle.hpp>
#include <detray/propagator/propagation_config.hpp>

namespace traccc {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
#include "traccc/edm/track_parameters.hpp"
#include "traccc/edm/track_state.hpp"

// Detray inlcude(s)
#include <detray/geometry/shapes/line.hpp>

namespace traccc {

/// Type unrolling functor to smooth the track parameters after the Kalman
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
#include "traccc/definitions/track_parametrization.hpp"
#include "traccc/edm/track_state.hpp"

// Detray inlcude(s)
#include <detray/geometry/shapes/line.hpp>

namespace traccc {

/// Type unrolling functor for Kalman updating
Expand Down
2 changes: 1 addition & 1 deletion core/include/traccc/fitting/kalman_filter/kalman_actor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "traccc/utils/particle.hpp"

// detray include(s).
#include "detray/propagator/base_actor.hpp"
#include <detray/propagator/base_actor.hpp>

namespace traccc {

Expand Down
12 changes: 6 additions & 6 deletions core/include/traccc/fitting/kalman_filter/kalman_fitter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
#include "traccc/utils/particle.hpp"

// detray include(s).
#include "detray/propagator/actor_chain.hpp"
#include "detray/propagator/actors/aborters.hpp"
#include "detray/propagator/actors/parameter_resetter.hpp"
#include "detray/propagator/actors/parameter_transporter.hpp"
#include "detray/propagator/actors/pointwise_material_interactor.hpp"
#include "detray/propagator/propagator.hpp"
#include <detray/propagator/actor_chain.hpp>
#include <detray/propagator/actors/aborters.hpp>
#include <detray/propagator/actors/parameter_resetter.hpp>
#include <detray/propagator/actors/parameter_transporter.hpp>
#include <detray/propagator/actors/pointwise_material_interactor.hpp>
#include <detray/propagator/propagator.hpp>

// System include(s).
#include <limits>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "traccc/definitions/qualifiers.hpp"

// Detray include(s).
#include "detray/propagator/base_actor.hpp"
#include <detray/propagator/base_actor.hpp>

// VecMem include(s).
#include <vecmem/utils/debug.hpp>
Expand Down
2 changes: 1 addition & 1 deletion core/include/traccc/seeding/impl/spacepoint_formation.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "traccc/definitions/primitives.hpp"

// Detray include(s).
#include "detray/geometry/tracking_surface.hpp"
#include <detray/geometry/tracking_surface.hpp>

namespace traccc::details {

Expand Down
2 changes: 1 addition & 1 deletion core/include/traccc/utils/particle.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "traccc/edm/track_parameters.hpp"

// detray include(s).
#include "detray/definitions/pdg_particle.hpp"
#include <detray/definitions/pdg_particle.hpp>

// System include(s).
#include <stdexcept>
Expand Down
18 changes: 9 additions & 9 deletions core/include/traccc/utils/seed_generator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
#include "traccc/edm/track_parameters.hpp"

// detray include(s).
#include "detray/geometry/barcode.hpp"
#include "detray/geometry/tracking_surface.hpp"
#include "detray/propagator/actor_chain.hpp"
#include "detray/propagator/actors/aborters.hpp"
#include "detray/propagator/actors/parameter_resetter.hpp"
#include "detray/propagator/actors/parameter_transporter.hpp"
#include "detray/propagator/actors/pointwise_material_interactor.hpp"
#include "detray/propagator/base_actor.hpp"
#include "detray/propagator/propagator.hpp"
#include <detray/geometry/barcode.hpp>
#include <detray/geometry/tracking_surface.hpp>
#include <detray/propagator/actor_chain.hpp>
#include <detray/propagator/actors/aborters.hpp>
#include <detray/propagator/actors/parameter_resetter.hpp>
#include <detray/propagator/actors/parameter_transporter.hpp>
#include <detray/propagator/actors/pointwise_material_interactor.hpp>
#include <detray/propagator/base_actor.hpp>
#include <detray/propagator/propagator.hpp>

// System include(s).
#include <random>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <limits>
#include <map>
#include <set>
#include <sstream>
#include <unordered_map>
#include <vector>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
// Project include(s).
#include "traccc/fitting/kalman_filter/gain_matrix_updater.hpp"

// Detray include(s)
#include <detray/geometry/tracking_surface.hpp>

// Thrust include(s).
#include <thrust/binary_search.h>
#include <thrust/execution_policy.h>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
#include "traccc/utils/particle.hpp"

// Detray include(s).
#include "detray/propagator/constrained_step.hpp"
#include "detray/utils/tuple_helpers.hpp"
#include <detray/propagator/constrained_step.hpp>
#include <detray/utils/tuple_helpers.hpp>

namespace traccc::device {

Expand Down
12 changes: 6 additions & 6 deletions device/cuda/include/traccc/cuda/finding/finding_algorithm.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@
#include "traccc/utils/memory_resource.hpp"

// detray include(s).
#include "detray/propagator/actor_chain.hpp"
#include "detray/propagator/actors/aborters.hpp"
#include "detray/propagator/actors/parameter_resetter.hpp"
#include "detray/propagator/actors/parameter_transporter.hpp"
#include "detray/propagator/actors/pointwise_material_interactor.hpp"
#include "detray/propagator/propagator.hpp"
#include <detray/propagator/actor_chain.hpp>
#include <detray/propagator/actors/aborters.hpp>
#include <detray/propagator/actors/parameter_resetter.hpp>
#include <detray/propagator/actors/parameter_transporter.hpp>
#include <detray/propagator/actors/pointwise_material_interactor.hpp>
#include <detray/propagator/propagator.hpp>

// VecMem include(s).
#include <vecmem/utils/copy.hpp>
Expand Down
10 changes: 5 additions & 5 deletions device/cuda/src/finding/finding_algorithm.cu
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@
#include "traccc/utils/projections.hpp"

// detray include(s).
#include "detray/detectors/bfield.hpp"
#include "detray/navigation/navigator.hpp"
#include "detray/propagator/rk_stepper.hpp"
#include "vecmem/containers/data/vector_view.hpp"
#include "vecmem/memory/unique_ptr.hpp"
#include <detray/detectors/bfield.hpp>
#include <detray/navigation/navigator.hpp>
#include <detray/propagator/rk_stepper.hpp>

// VecMem include(s).
#include <vecmem/containers/data/vector_buffer.hpp>
#include <vecmem/containers/data/vector_view.hpp>
#include <vecmem/containers/device_vector.hpp>
#include <vecmem/containers/jagged_device_vector.hpp>
#include <vecmem/containers/vector.hpp>
#include <vecmem/memory/unique_ptr.hpp>

// Thrust include(s).
#include <thrust/copy.h>
Expand Down
Loading
Loading