Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide default propagation options by proper units #868

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

beomki-yeo
Copy link
Contributor

Currently overstep tolerenace is set to -300 um (detray default) * um = -0.3 um, which makes propagation unstable

@beomki-yeo beomki-yeo added the bug Something isn't working label Feb 13, 2025
@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Feb 13, 2025

@stephenswat It seems that we (at least I...) were shadow-boxing recently with too small overstep tolerance :/ ...

Copy link

@beomki-yeo beomki-yeo merged commit e0812ba into acts-project:main Feb 14, 2025
29 checks passed
@stephenswat
Copy link
Member

Thanks for this PR, but please do note that this change breaks the idea that the defaults for the CLI options are taken from the defaults for the configuration objects. Now we are back to a scenario where the CLI defaults are different; I'll aim to fix this in a new PR today.

@stephenswat
Copy link
Member

Never mind the aforementioned is incorrect and all is well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants