Divide default propagation options by proper units #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenswat It seems that we (at least I...) were shadow-boxing recently with too small overstep tolerance :/ ... |
niermann999
approved these changes
Feb 13, 2025
|
|
Thanks for this PR, but please do note that this change breaks the idea that the defaults for the CLI options are taken from the defaults for the configuration objects. Now we are back to a scenario where the CLI defaults are different; I'll aim to fix this in a new PR today. |
|
Never mind the aforementioned is incorrect and all is well. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently overstep tolerenace is set to -300 um (detray default) * um = -0.3 um, which makes propagation unstable