Abort backward propagation when path length gets too negative #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
added
bug
beomki-yeo
force-pushed
the
abort-back-prop-with-neg-path
branch
2 times, most recently
from
4f1c05c to
bf2632c
Compare
beomki-yeo
force-pushed
the
abort-back-prop-with-neg-path
branch
from
bf2632c to
18be934
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, backward propagation may not stop even after going through the vol 0.
This PR aborts the backward propagation if the total path length (forward path length + backward path length) becomes too negative (< -50 mm)
This will also revive the continuous benchmark stopped by #714