Add pre-commit job to check quote includes #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Apart from that stylistic issue with indentation, I'm on board. This is my coding preference as well.
I wonder if there may be a possibility of checking include orders as well (I prefer going from the "more local" to the "more generic" ones), but that's not for this PR.
Include order is checked via clang-format! |
PR acts-project#865 moved our detray includes from quotes to angle brackets, which I like a lot. This commit adds a new pre-commit job to check that this doesn't regress, and makes the same change for our other dependencies.
stephenswat
force-pushed
the
ci/quoted_includes
branch
from
5cdb169 to
864d5fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #865 moved our detray includes from quotes to angle brackets, which I like a lot. This commit adds a new pre-commit job to check that this doesn't regress, and makes the same change for our other dependencies.