Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit job to check quote includes #871

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

stephenswat
Copy link
Member

PR #865 moved our detray includes from quotes to angle brackets, which I like a lot. This commit adds a new pre-commit job to check that this doesn't regress, and makes the same change for our other dependencies.

@stephenswat stephenswat added the cicd Changes related to the CI system label Feb 17, 2025
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that stylistic issue with indentation, I'm on board. This is my coding preference as well.

I wonder if there may be a possibility of checking include orders as well (I prefer going from the "more local" to the "more generic" ones), but that's not for this PR.

@stephenswat
Copy link
Member Author

I wonder if there may be a possibility of checking include orders as well (I prefer going from the "more local" to the "more generic" ones), but that's not for this PR.

Include order is checked via clang-format!

PR acts-project#865 moved our detray includes from quotes to angle brackets, which I
like a lot. This commit adds a new pre-commit job to check that this
doesn't regress, and makes the same change for our other dependencies.
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephenswat stephenswat merged commit c64aac6 into acts-project:main Feb 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Changes related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants