Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporarily switch the smoother type in benchmark #880

Closed
wants to merge 1 commit into from

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Feb 20, 2025

Switch the smoother type to prevent a segfault until the direct navigator can be deployed. Also reanables correct navigation.

@niermann999
Copy link
Contributor Author

I tried this in the ubuntu cuda docker container that is run for the benchmark jobs and it seems to fix the issue. But it would be great, if somebody could check

@beomki-yeo
Copy link
Contributor

As we discussed earlier, I will introduce the direct navigator soon so please hold the PR.

@beomki-yeo
Copy link
Contributor

beomki-yeo commented Feb 21, 2025

#882 will fix the current issue of seg fault.

@niermann999
Copy link
Contributor Author

niermann999 commented Feb 21, 2025

As we discussed earlier, I will introduce the direct navigator soon so please hold the PR.

The point is, that with a broken navigation the simulation step will not produce up to 30% of hits. Then the CKF might also miss a similar amount of sensitive surfaces during navigation. At the same time it needs to get more than three hits to make a track in a detector that has four barrel layers.
I hear you that the smoothing would produce garbage after this PR, but if we leave the navigation broken, I am worried that the entire chain is affected and the throughput that is currently being reported in the benchmark is not anywhere near accurate. Would it not be better if the chain works up until the smoother at least?

@beomki-yeo
Copy link
Contributor

No worries. I will deliver the solution soon.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants