Fix edge case detection in CPU track finding #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
fix/cpu_track_finding
branch
from
9ffade8 to
47dedee
Compare
This commit fixes a critial bug in the CPU track finding where it is not able to deal with cases where the previous step ID is `U?INT_MAX`. This is used to indicate that we are in the first step. The fix in this commit is two-pronged: 1. This commit ensures that invalid step IDs are skipped through. 2. This commit ensures that the invalid step ID value is properly set; we were previously comparing `UINT_MAX` with `INT_MAX` which are obviously different. I also sprinkled around some `at` calls to replace `operator[]` for better error handling.
stephenswat
force-pushed
the
fix/cpu_track_finding
branch
from
47dedee to
c3722dc
Compare
|
Let me update the branch and merge.. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a critial bug in the CPU track finding where it is not able to deal with cases where the previous step ID is
U?INT_MAX. This is used to indicate that we are in the first step. The fix in this commit is two-pronged:UINT_MAXwithINT_MAXwhich are obviously different.I also sprinkled around some
atcalls to replaceoperator[]for better error handling.