Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case detection in CPU track finding #884

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

stephenswat
Copy link
Member

This commit fixes a critial bug in the CPU track finding where it is not able to deal with cases where the previous step ID is U?INT_MAX. This is used to indicate that we are in the first step. The fix in this commit is two-pronged:

  1. This commit ensures that invalid step IDs are skipped through.
  2. This commit ensures that the invalid step ID value is properly set; we were previously comparing UINT_MAX with INT_MAX which are obviously different.

I also sprinkled around some at calls to replace operator[] for better error handling.

@stephenswat stephenswat added bug Something isn't working cpu Changes related to CPU code labels Feb 21, 2025
@stephenswat stephenswat force-pushed the fix/cpu_track_finding branch from 9ffade8 to 47dedee Compare February 21, 2025 12:21
This commit fixes a critial bug in the CPU track finding where it is not
able to deal with cases where the previous step ID is `U?INT_MAX`. This
is used to indicate that we are in the first step. The fix in this
commit is two-pronged:

1. This commit ensures that invalid step IDs are skipped through.
2. This commit ensures that the invalid step ID value is properly set;
   we were previously comparing `UINT_MAX` with `INT_MAX` which are
   obviously different.

I also sprinkled around some `at` calls to replace `operator[]` for
better error handling.
@stephenswat stephenswat force-pushed the fix/cpu_track_finding branch from 47dedee to c3722dc Compare February 21, 2025 12:24
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@beomki-yeo
Copy link
Contributor

Let me update the branch and merge..

@beomki-yeo beomki-yeo merged commit 9f19442 into acts-project:main Feb 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpu Changes related to CPU code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants