Set particle hypothesis in Kálmán fitter #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are not actually setting the particle hypothesis in the
Kálmán fitter, which I find leads to some assertions about the sign of
the $\frac{q}{p}$ value not being equal to the sign of $q$. This commit
enforces the particle hypothesis in the fitter and adds an additional
assert to ensure that the operation was successful.
stephenswat
force-pushed
the
fix/fitter_set_ptc_hypothesis
branch
from
4efee2d to
1c28dc2
Compare
beomki-yeo
approved these changes
Feb 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are not actually setting the particle hypothesis in the Kálmán fitter, which I find leads to some assertions about the sign of the$\frac{q}{p}$ value not being equal to the sign of $q$ . This commit enforces the particle hypothesis in the fitter and adds an additional assert to ensure that the operation was successful.