Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set particle hypothesis in Kálmán fitter #885

Merged

Conversation

stephenswat
Copy link
Member

@stephenswat stephenswat commented Feb 21, 2025

Currently, we are not actually setting the particle hypothesis in the Kálmán fitter, which I find leads to some assertions about the sign of the $\frac{q}{p}$ value not being equal to the sign of $q$. This commit enforces the particle hypothesis in the fitter and adds an additional assert to ensure that the operation was successful.

@stephenswat stephenswat added the bug Something isn't working label Feb 21, 2025
Currently, we are not actually setting the particle hypothesis in the
Kálmán fitter, which I find leads to some assertions about the sign of
the $\frac{q}{p}$ value not being equal to the sign of $q$. This commit
enforces the particle hypothesis in the fitter and adds an additional
assert to ensure that the operation was successful.
@stephenswat stephenswat force-pushed the fix/fitter_set_ptc_hypothesis branch from 4efee2d to 1c28dc2 Compare February 21, 2025 12:27
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right Thanks for the fix

@beomki-yeo beomki-yeo merged commit 345a2a5 into acts-project:main Feb 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants