VecMem 1.14.0, main branch (2025.02.21.) #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
force-pushed
the
ModernSoA-main-20250221
branch
from
1051ee2 to
e1f72b6
Compare
krasznaa
commented
Feb 21, 2025
beomki-yeo
approved these changes
Feb 21, 2025
Most importantly, make use of vecmem::edm::host::push_back(...) as a result.
krasznaa
force-pushed
the
ModernSoA-main-20250221
branch
from
e1f72b6 to
3e0f13a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to vecmem-1.14.0. Which brings in a number of updates, but most importantly the ability to use
vecmem::edm::host::push_back(...)andvecmem::edm::device::push_back(...)to add elements to (resizable) SoA containers.I modified a couple of places in the code where this makes the code a little more readable with the existing SoA containers. But didn't go through absolutely everything.
Most importantly, this will help make #878 be a little more readable in the test code.