Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the track parameter assertions after updating the track parameters #888

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Feb 25, 2025

The current assertion is done before the updating track parameter which seems not necessary. This should come after the update of track parameters.

Also added the assertion for non-zero qop.

@beomki-yeo beomki-yeo added the bug Something isn't working label Feb 25, 2025
@stephenswat stephenswat merged commit 53b8e46 into acts-project:main Feb 25, 2025
29 checks passed
krasznaa pushed a commit to krasznaa/traccc that referenced this pull request Feb 25, 2025
Run the track parameter assertions after updating the track parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants