Fix SFINAE bug in container base type #890
Merged
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
approved these changes
Feb 25, 2025
krasznaa
approved these changes
Feb 25, 2025
TIL 😆 |
stephenswat
force-pushed
the
fix/container_base_sfinae
branch
from
52394d9 to
aa65d4f
Compare
This commit fixes a bug in the use of SFINAE in the container base type. In particuler, this issue has three layers: 1. The existing code uses the `typename = std::enable_if` anti-pattern which is discouraged in the C++ standard. 2. The code used `std::enable_if` without getting `::type` from it, meaning that a specialization failure cannot ever occur, rendering the SFINAE useless. 3. The check used about type equality is incorrect, it should rather check constructability. This commit fixes the issues by converting the code to a C++20 requires clause and by modifying the conditions.
stephenswat
force-pushed
the
fix/container_base_sfinae
branch
from
aa65d4f to
3be3318
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the use of SFINAE in the container base type. In particuler, this issue has three layers:
typename = std::enable_ifanti-pattern which is discouraged in the C++ standard.std::enable_ifwithout getting::typefrom it, meaning that a specialization failure cannot ever occur, rendering the SFINAE useless.This commit fixes the issues by converting the code to a C++20 requires clause and by modifying the conditions.