Protect against negative chi-square in updater #895
Conversation
There was a problem hiding this comment.
Up to Beomki to say the final word, but from my side, sure, this looks sane.
I don't think it makes any difference for the GPU compilers, but would it make sense to add [[unlikely]] on these checks? 🤔
https://en.cppreference.com/w/cpp/language/attributes/likely
|
Rigorously speaking, it is an error. The question is how frequently this happens. If it happens for 99% of tracks.. maybe we should ignore 💀 |
|
Meanwhile, the error also needs to be included in the two filters smoother :) |
https://github.com/acts-project/traccc/pull/886/files 😉 |
stephenswat
force-pushed
the
bug/negative_chi2
branch
from
20efb5f to
202150c
Compare
I've updated the two-filter smoother, now! |
stephenswat
force-pushed
the
bug/negative_chi2
branch
from
202150c to
1cbd0fb
Compare
stephenswat
force-pushed
the
bug/negative_chi2
branch
from
1cbd0fb to
04511e2
Compare
core/include/traccc/fitting/kalman_filter/gain_matrix_smoother.hpp
Outdated
Show resolved
Hide resolved
core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp
Outdated
Show resolved
Hide resolved
core/include/traccc/fitting/kalman_filter/two_filters_smoother.hpp
Outdated
Show resolved
Hide resolved
I've observed an issue in which the gain matrix updater sometimes produces $\chi^2$ values less than zero, which makes no sense. This commit adds a check for this condition and returns an appropriate error state.
stephenswat
force-pushed
the
bug/negative_chi2
branch
from
04511e2 to
2a17368
Compare
|
Okay, I've updated the return values. |
|
I've observed an issue in which the gain matrix updater sometimes produces$\chi^2$ values less than zero, which makes no sense. This commit adds a check for this condition and returns an appropriate error state.