Remove placement from detector description which is not necessary #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think by now we're basically at the point that we could drip the old-style TML geometry from the code. 🤔 I was thinking about doing that recently myself as well, when I updated the executables to use the ODD by default. If the CI succeeds with this, I'm not against this simplification at all. |
|
OK! |
beomki-yeo
force-pushed
the
remove-placement
branch
from
b77c8de to
b673024
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traccc::io::csv::read_surfacesalso needs to be fixed as it does not have to returntransform3at all. But that will require removing entire csv support.