Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placement from detector description which is not necessary #899

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

beomki-yeo
Copy link
Contributor

traccc::io::csv::read_surfaces also needs to be fixed as it does not have to return transform3 at all. But that will require removing entire csv support.

@beomki-yeo beomki-yeo added the bug Something isn't working label Feb 27, 2025
@krasznaa
Copy link
Member

I think by now we're basically at the point that we could drip the old-style TML geometry from the code. 🤔 I was thinking about doing that recently myself as well, when I updated the executables to use the ODD by default.

If the CI succeeds with this, I'm not against this simplification at all.

@beomki-yeo
Copy link
Contributor Author

OK!

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beomki-yeo beomki-yeo merged commit 27e7891 into acts-project:main Feb 28, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants