Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertions in Kálmán filter and fitter #900

Merged

Conversation

stephenswat
Copy link
Member

This commit makes some improvements to the assertions in the Kálmán filter and fitter. Namely, it asserts that the number of measurements added in the track building kernel is the correct number, and it asserts that none of the measurements are duplicated. In the fitting kernel, the assertion on the fitting status is loosened.

@stephenswat stephenswat added improvement Improve an existing feature shared Changes related to shared code labels Feb 28, 2025
This commit makes some improvements to the assertions in the Kálmán
filter and fitter. Namely, it asserts that the number of measurements
added in the track building kernel is the correct number, and it asserts
that none of the measurements are duplicated. In the fitting kernel, the
assertion on the fitting status is loosened.
@stephenswat stephenswat force-pushed the feat/finding_fitting_asserts branch from b8e7893 to 592ebaf Compare February 28, 2025 13:21
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allocating a unique measurement_id has been optional but this PR somehow makes it mandatory, which is not bad

@beomki-yeo beomki-yeo merged commit c176147 into acts-project:main Mar 1, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve an existing feature shared Changes related to shared code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants