Improve assertions in Kálmán filter and fitter #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
improvement
This commit makes some improvements to the assertions in the Kálmán filter and fitter. Namely, it asserts that the number of measurements added in the track building kernel is the correct number, and it asserts that none of the measurements are duplicated. In the fitting kernel, the assertion on the fitting status is loosened.
stephenswat
force-pushed
the
feat/finding_fitting_asserts
branch
from
b8e7893 to
592ebaf
Compare
|
beomki-yeo
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes some improvements to the assertions in the Kálmán filter and fitter. Namely, it asserts that the number of measurements added in the track building kernel is the correct number, and it asserts that none of the measurements are duplicated. In the fitting kernel, the assertion on the fitting status is loosened.