Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inconsistent CKF options #904

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Mar 5, 2025

nmax-per-seed options overlaps with max-num-branches-per-seed, and "Max branches per step" is different from max_num_branches_per_seed I guess

@beomki-yeo beomki-yeo requested a review from stephenswat March 5, 2025 19:04
@beomki-yeo beomki-yeo added the bug Something isn't working label Mar 5, 2025
@beomki-yeo beomki-yeo force-pushed the clean-up-ckf-options branch from cb44b33 to 7f3f5a5 Compare March 5, 2025 20:07
Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stephenswat stephenswat merged commit 1de0fab into acts-project:main Mar 6, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants