Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rocprim version to 6.1.1 #905

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

StewMH
Copy link
Contributor

@StewMH StewMH commented Mar 6, 2025

Required for #901 and fixes the compilation error seen there:

  324 |     if(stream == default_stream || stream == hipStreamPerThread || stream == hipStreamLegacy)

After investigation I opened a rocThrust bug (ROCm/rocThrust#527) - we are picking up the tip of the develop branch for rocprim (a rocThrust dependency), which is no longer compatible with rocm-6.1.1. Fix this in the patch.

Additionally, so this can be tested, start building rocThrust and related test code in HIP Alpaka flavour.

@StewMH
Copy link
Contributor Author

StewMH commented Mar 6, 2025

cc @CrossR

Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the fact that RocThrust depends on a develop branch is pretty worrying!

@stephenswat
Copy link
Member

By the way, your git client is still not set up correctly; the user is set to Stewart Martin-Haugh stewart.martin-haugh@stfc.ac.uk <smh@cern.ch> rather than either Stewart Martin-Haugh <smh@cern.ch> or Stewart Martin-Haugh <stewart.martin-haugh@stfc.ac.uk>. Doesn't affect your ability to make PRs but it does affect GitHub's ability to credit you for them.

@stephenswat stephenswat merged commit 85dc207 into acts-project:main Mar 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants