SoA Proxy Updates, main branch (2025.02.20.) #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
commented
Feb 20, 2025
krasznaa
force-pushed
the
SoAProxyUpdate-main-20250220
branch
from
1593e7c to
9d21e37
Compare
Just because I intend to use "proxy type" for a different thing shortly.
Without making any meaningful use of it yet.
krasznaa
force-pushed
the
SoAProxyUpdate-main-20250220
branch
2 times, most recently
from
63ba931 to
d3cc47d
Compare
|
Is this still under development or is it ready for review? |
|
Please have a look. By now it's in a shape that I'm fairly happy with. |
krasznaa
commented
Feb 21, 2025
krasznaa
force-pushed
the
SoAProxyUpdate-main-20250220
branch
from
d3cc47d to
38fdcdb
Compare
stephenswat
reviewed
Feb 21, 2025
krasznaa
force-pushed
the
SoAProxyUpdate-main-20250220
branch
from
38fdcdb to
510ef56
Compare
|
stephenswat
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by @beomki-yeo's insistence in acts-project/traccc#878, I spent a bit of time trying to come up with a way of filling SoA containers conveniently "by hand".
I considered a number of options, but in the end went with making
vecmem::edm::proxyeven a bit more complicated. 🤔 Instead of only being able to refer to (i.e. "proxy"...) an element of a container, now they can also behave as standalone objects, which hold some payload of their own.I went with this, because if I introduced a new type for this (let's say
vecmem::edm::object), I would've had to create conversion operators back and forth between the new type andvecmem::edm::proxy. So it was easier to just use the same type for the standalone objects as well.So far I only added
vecmem::edm::host::push_back(...)with the new machinery, just as a proof of concept. Along with some testing code for it. Please have a look, especially at the unit test code. Since some early feedback could be useful here.Note that it will never be possible to use such a formalism on containers that have jagged vectors, in device code. (Since a dynamic sized vector cannot be used in device code for this.) But since SoA containers with jagged vectors are not resizable to begin with, that is not a new limitation actually... 🤔