-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix privacy filter #3472
Merged
Merged
Fix privacy filter #3472
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
400cbf8
Fix privacy filter
joel-jeremy 9c57cef
Release notes
joel-jeremy a049179
Coderabbit suggestion
joel-jeremy 7ceea91
VRT
joel-jeremy fabd153
VRT
joel-jeremy 90c92ff
Revert VRT
joel-jeremy 18630df
VRT
joel-jeremy 2348899
VRT
joel-jeremy 01a5d04
VRT
joel-jeremy c8dee4c
VRT
joel-jeremy a210dc4
Delete VRT
joel-jeremy c9efe37
VRT
joel-jeremy df424e0
Revert VRT
joel-jeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+1.99 KB
(100%)
...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has a change in this PR altered the default theme from
light?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. There's no theme changes in this PR. This could be what's causing the flakiness in the VRT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the screenshot, re-ran the VRT and it failed. I re-run the VRT again, and it now succeeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, definitely some odd flakes flying about. If we could get to the bottom of the fatal error on the rules page it would be a good start. I'll see if I can add some debugging and rerun locally until it fails.