Visually deconflict sync status from notifications button #3547

afv22 · 2024-10-02T22:05:18Z

Fixes #3536

Increasing stack placement of the "Syncing..." alert so it does not visually conflict with the notifications button.

Before

After

netlify · 2024-10-02T22:05:34Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`4578404`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/670028bd305a300008f222ab
😎 Deploy Preview	https://deploy-preview-3547.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-10-02T22:06:28Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.29 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	20.96 kB	0%
static/js/narrow.js	81.98 kB	0%
static/js/wide.js	225.26 kB	0%
static/js/ReportRouter.js	1.5 MB	0%
static/js/index.js	3.32 MB	0%

github-actions · 2024-10-02T22:06:29Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

coderabbitai · 2024-10-02T22:25:33Z

Walkthrough

The pull request modifies the BankSyncStatus component by adjusting the left style property to '50%', adding a transform property to center the component horizontally, and updating the zIndex from 501 to 1000 to change its stacking order. Additionally, a new whiteSpace property is added with the value 'nowrap'. No other functional or structural changes are made.

Changes

File Path	Change Summary
`packages/desktop-client/src/components/BankSyncStatus.tsx`	Adjusted `left` to `'50%'`, added `transform: translate(-50%)`, updated `zIndex` to `1000`, and added `whiteSpace: 'nowrap'`.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve overlapping notifications (#3536)	✅

Possibly related PRs

🐛 (bank-sync) fix initial sync - close modal stack, show loading indicators #3540: The changes in the SelectLinkedAccountsModal.jsx file involve modifications to the modal's behavior, which may relate to the BankSyncStatus component's visual presentation and user interaction during the bank synchronization process.

Suggested labels

:sparkles: Merged

Suggested reviewers

joel-jeremy
MatissJanis

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

packages/desktop-client/src/components/BankSyncStatus.tsx (1)
Line range hint 1-72: Consider improvements for accessibility, customization, and testing.

While the current implementation addresses the immediate issue, here are some suggestions to enhance the component:
Accessibility: Add appropriate ARIA attributes to improve screen reader support. For example:
<View
  role="status"
  aria-live="polite"
  aria-atomic="true"
>
  {/* ... */}
</View>
Customization: Consider extracting the styles into a separate constant or using a theming system for easier customization. This could make future adjustments simpler.
Testing: Add test IDs to key elements to facilitate easier testing. For example:
<View data-testid="bank-sync-status">
  {/* ... */}
</View>
Would you like me to provide more detailed code examples for these improvements?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 125510c and 4c9fb58.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/3547.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/src/components/BankSyncStatus.tsx (1 hunks)

packages/desktop-client/src/components/BankSyncStatus.tsx

afv22 · 2024-10-04T15:52:59Z

Updated the CSS block for the 'Syncing...' notification to float in the center instead of stretching to either side, which was blocking interaction with the elements behind it.

Hover 'Syncing' animation over notification button

aa93d79

actual-github-bot bot added the 🚧 WIP label Oct 2, 2024

afv22 changed the title ~~[WIP] Hover 'Syncing' animation over notification button~~ [WIP] Stack 'Syncing' animation over notification button Oct 2, 2024

Add release note

4c9fb58

afv22 changed the title ~~[WIP] Stack 'Syncing' animation over notification button~~ [WIP] Visually deconflict sync status from notifications button Oct 2, 2024

afv22 changed the title ~~[WIP] Visually deconflict sync status from notifications button~~ Visually deconflict sync status from notifications button Oct 2, 2024

afv22 marked this pull request as ready for review October 2, 2024 22:25

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Oct 2, 2024

coderabbitai bot reviewed Oct 2, 2024

View reviewed changes

packages/desktop-client/src/components/BankSyncStatus.tsx Show resolved Hide resolved

afv22 marked this pull request as draft October 2, 2024 22:36

actual-github-bot bot added 🚧 WIP and removed 🔍 Ready for review labels Oct 2, 2024

afv22 and others added 2 commits October 4, 2024 15:47

Center Syncing notification without blocking background elements

2c1f25e

Merge branch 'actualbudget:master' into master

2a1fb18

afv22 marked this pull request as ready for review October 4, 2024 15:53

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Oct 4, 2024

Merge branch 'actualbudget:master' into master

4578404

afv22 deleted the branch actualbudget:master October 4, 2024 19:14

afv22 closed this Oct 4, 2024

afv22 deleted the master branch October 4, 2024 19:14

actual-github-bot bot removed the 🔍 Ready for review label Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visually deconflict sync status from notifications button #3547

Visually deconflict sync status from notifications button #3547

afv22 commented Oct 2, 2024

netlify bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

coderabbitai bot commented Oct 2, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

afv22 commented Oct 4, 2024

Visually deconflict sync status from notifications button #3547

Visually deconflict sync status from notifications button #3547

Conversation

afv22 commented Oct 2, 2024

Before

After

netlify bot commented Oct 2, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Oct 2, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Oct 2, 2024 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Oct 2, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

afv22 commented Oct 4, 2024

netlify bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

coderabbitai bot commented Oct 2, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)