[WIP] Add Financial Institution Column to Link Accounts Modal #3579

UnInfamous · 2024-10-05T18:42:57Z

coderabbitai · 2024-10-05T18:43:05Z

Walkthrough

The pull request introduces updates to the SelectLinkedAccountsModal component within the SelectLinkedAccountsModal.jsx file. A new column header labeled "Financial Institution" has been added to the TableHeader, improving the visibility of the financial institutions associated with linked accounts. Correspondingly, the TableRow component has been modified to include a new Field that displays the name of the financial institution for each external account, sourced from the org property of the externalAccount object. Minor layout adjustments have been made to ensure that this new field integrates well with the existing functionality of the modal. Importantly, the core logic for linking and unlinking accounts remains unchanged, maintaining the modal's original control flow.

Assessment against linked issues

Objective	Addressed	Explanation
Add a column named Financial Institution to the Link Accounts Modal (3529)	✅

Possibly related PRs

🐛 (bank-sync) fix initial sync - close modal stack, show loading indicators #3540: This PR modifies the SelectLinkedAccountsModal component to enhance user interaction by ensuring the modal closes after linking accounts, which relates to the overall functionality of the modal.

Suggested reviewers

matt-fidd: Suggested for review due to familiarity with the SelectLinkedAccountsModal component and its functionality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-10-05T18:43:14Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`ae21055`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67018bcdaa081b00088773e5
😎 Deploy Preview	https://deploy-preview-3579.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-10-05T18:45:20Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.3 MB → 5.3 MB (-416 B)	-0.01%

Changeset

File	Δ	Size
`src/components/modals/SelectLinkedAccountsModal.jsx`	📈 +242 B (+3.31%)	7.14 kB → 7.38 kB
`src/components/transactions/TransactionsTable.jsx`	📉 -500 B (-0.76%)	63.83 kB → 63.34 kB
`src/components/common/Button2.tsx`	📉 -158 B (-3.01%)	5.12 kB → 4.97 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.32 MB → 3.32 MB (+84 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/wide.js	225.75 kB → 225.26 kB (-500 B)	-0.22%

Unchanged

Asset	File Size	% Changed
static/js/resize-observer.js	18.37 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/narrow.js	82.55 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	20.96 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/ReportRouter.js	1.5 MB	0%

github-actions · 2024-10-05T18:45:21Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)

packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (3)
Line range hint 139-145: LGTM! Consider using a constant for column widths.

The addition of the "Financial Institution" column aligns well with the PR objectives, improving the visibility of account information. The implementation is straightforward and consistent with the existing structure.

For improved maintainability, consider defining a constant for common column widths (e.g., 200) used across multiple columns.

212-213: LGTM! Consider adding a fallback for missing institution names.

The addition of the financial institution field is well-implemented and aligns with the PR objectives. The use of optional chaining (?.) is a good practice to prevent errors.

Consider adding a fallback value or placeholder text for cases where externalAccount.org?.name might be undefined or empty. For example:
<Field width={200}>{externalAccount.org?.name || 'N/A'}</Field>
This ensures that users always see some information in the "Financial Institution" column, even if the data is missing.

Line range hint 1-262: Overall, the implementation successfully meets the PR objectives.

The changes effectively add the "Financial Institution" column to the Link Accounts Modal, addressing the feature request outlined in issue #3529. The implementation is consistent with the existing code structure and doesn't introduce any apparent issues.

Key points:

The new column is added to both the TableHeader and TableRow components.

The financial institution name is correctly sourced from the externalAccount.org?.name property.

The changes maintain the existing functionality of the modal.

The implementation improves the clarity of account information, making it easier for users to identify which financial institution each account belongs to when managing multiple accounts across different files.

To further enhance this feature, consider the following suggestions for future improvements:

Add sorting functionality for the new "Financial Institution" column.

Implement filtering options to allow users to view accounts from specific financial institutions.

Consider adding tooltips or info icons to provide more details about each financial institution when users hover over the name.

These enhancements would further improve the user experience and make it easier for users to manage their linked accounts.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 33a7524 and d531e4b.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/3529.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx (2 hunks)

Misunderstood it should be the PR # instead of the issue #.

github-actions · 2024-10-13T02:04:19Z

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

youngcw · 2024-10-15T15:08:11Z

Can this be made conditional maybe? Simplefin doesn't pass that info along, maybe its there, but not passed in. Also the extra width is cutting off some of the button

github-actions · 2024-10-24T02:00:55Z

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

github-actions · 2024-10-29T02:02:12Z

This PR was closed because it has been stalled for 5 days with no activity.

UnInfamous and others added 2 commits October 5, 2024 09:43

Add Financial Institution Column

da00a25

Add Financial Institution Column

b70d158

actual-github-bot bot changed the title ~~Add Financial Institution Column to Link Accounts Modal~~ [WIP] Add Financial Institution Column to Link Accounts Modal Oct 5, 2024

actual-github-bot bot added the 🚧 WIP label Oct 5, 2024

Merge branch 'master' into uninfamous-show-fi

d531e4b

coderabbitai bot reviewed Oct 5, 2024

View reviewed changes

Add Financial Institution Column to Link Accounts Modal

ae21055

Misunderstood it should be the PR # instead of the issue #.

github-actions bot added the Stale label Oct 13, 2024

github-actions bot removed the Stale label Oct 16, 2024

github-actions bot added the Stale label Oct 24, 2024

github-actions bot closed this Oct 29, 2024

actual-github-bot bot removed the 🚧 WIP label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add Financial Institution Column to Link Accounts Modal #3579

[WIP] Add Financial Institution Column to Link Accounts Modal #3579

UnInfamous commented Oct 5, 2024

coderabbitai bot commented Oct 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Oct 5, 2024 •

edited

Loading

github-actions bot commented Oct 5, 2024 •

edited

Loading

github-actions bot commented Oct 5, 2024 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Oct 13, 2024

youngcw commented Oct 15, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 29, 2024

[WIP] Add Financial Institution Column to Link Accounts Modal #3579

[WIP] Add Financial Institution Column to Link Accounts Modal #3579

Conversation

UnInfamous commented Oct 5, 2024

coderabbitai bot commented Oct 5, 2024 • edited Loading

Walkthrough

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Oct 5, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Oct 5, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Oct 5, 2024 • edited Loading

Bundle Stats — loot-core

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 13, 2024

youngcw commented Oct 15, 2024

github-actions bot commented Oct 24, 2024

github-actions bot commented Oct 29, 2024

coderabbitai bot commented Oct 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Oct 5, 2024 •

edited

Loading

github-actions bot commented Oct 5, 2024 •

edited

Loading

github-actions bot commented Oct 5, 2024 •

edited

Loading