✨ show the 'import transactions' button even if accounts have banksync

[MatissJanis]

Tiny quality of life improvement.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	2868eaf
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6706bc7935c081000842be8e
😎 Deploy Preview	https://deploy-preview-3615.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.31 MB → 5.31 MB (-148 B)	-0.00%

Changeset

File	Δ	Size
src/components/accounts/Header.jsx	📉 -148 B (-0.86%)	16.87 kB → 16.72 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/wide.js	224.88 kB → 224.74 kB (-148 B)	-0.06%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/AppliedFilters.js	20.96 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.55 kB	0%
static/js/ReportRouter.js	1.51 MB	0%
static/js/index.js	3.33 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.26 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.26 MB	0%

[coderabbitai]

Walkthrough

The pull request introduces changes to the AccountHeader component located in Header.jsx. The primary modification involves the conditional rendering logic for the sync button, which now only checks if syncing is possible (canSync). The previous checks for whether the account was closed have been removed. The onPress handler for the sync button has been simplified to consistently call onSync, and the isDisabled property is now determined solely by the isServerOffline status. Additionally, the content rendering of the sync button has been streamlined; it will now always display an AnimatedRefresh icon along with text that reflects the server status, eliminating the previous conditional rendering for the button's label and icon. The import button is also rendered unconditionally when the account is not closed, separating it from the sync button's logic. These adjustments aim to enhance the clarity and maintainability of the component.

Possibly related PRs

• 🐛 (bank-sync) fix initial sync - close modal stack, show loading indicators #3540: Modifies the SelectLinkedAccountsModal component, which may interact with account synchronization processes similar to the changes in the AccountHeader component.
• Update sidebar scrolling #3554: Updates the Accounts component, directly related to account management and potentially sharing functionality with the AccountHeader component.

Suggested labels

sparkles: Merged

Suggested reviewers

• youngcw

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f786bdc and 2868eaf.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/3615.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/components/accounts/Header.jsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

packages/desktop-client/src/components/accounts/Header.jsx (2)

290-308: LGTM! Sync button rendering simplified and improved.

The changes to the sync button rendering logic are well-implemented:

1. Simplified conditional rendering improves code readability.
2. Consistent onPress handler enhances maintainability.
3. Streamlined button content provides a more uniform user experience.

These modifications align well with the PR objective and contribute to a better overall user interface.

---

310-319: LGTM! Import button now consistently available.

The changes to the import button rendering are excellent:

1. The button is now displayed for all non-closed accounts, regardless of sync status.
2. This modification directly fulfills the PR objective of showing the 'import transactions' button even for accounts with banksync.
3. Separating the import button logic from the sync button enhances code clarity and maintainability.

These improvements provide users with more consistent access to manual transaction imports, enhancing the overall user experience.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[youngcw]

Looks good!