Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #3719: Imported payee overflowing on transaction record #3753

Merged

Conversation

JahJoey
Copy link
Contributor

@JahJoey JahJoey commented Oct 30, 2024

Fix #3719

@actual-github-bot actual-github-bot bot changed the title Fix: #3719: Imported payee overflowing on transaction record [WIP] Fix: #3719: Imported payee overflowing on transaction record Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4592936
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6721a715060c4300085646cd
😎 Deploy Preview https://deploy-preview-3753.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.32 MB → 5.32 MB (+24 B) +0.00%
Changeset
File Δ Size
src/components/common/Tooltip.tsx 📈 +24 B (+1.71%) 1.37 kB → 1.4 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.33 MB → 3.33 MB (+24 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/usePreviewTransactions.js 1.64 kB 0%
static/js/AppliedFilters.js 21.3 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 82.57 kB 0%
static/js/wide.js 232.16 kB 0%
static/js/ReportRouter.js 1.5 MB 0%

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.27 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.27 MB 0%

@matt-fidd
Copy link
Contributor

Hey! Is this ready for review? If so, please could you remove the [WIP] from the title and it'll open it up for us.

@JahJoey
Copy link
Contributor Author

JahJoey commented Nov 4, 2024

Hey! Is this ready for review? If so, please could you remove the [WIP] from the title and it'll open it up for us.

Sorry about that didn't realize.

@JahJoey JahJoey changed the title [WIP] Fix: #3719: Imported payee overflowing on transaction record Fix: #3719: Imported payee overflowing on transaction record Nov 4, 2024
Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Walkthrough

The changes made in the Tooltip.tsx file focus on the styling of the View component within the Tooltip component. A new property, maxWidth: '100%', has been added to the style prop of the View component. This adjustment ensures that the tooltip does not exceed the width of its container, thereby enhancing layout constraints. The existing logic for pointer events, managed by the handlePointerEnter and handlePointerLeave functions, remains unchanged. Additionally, the effect that resets the hover state in response to changes in triggerProps.isDisabled is retained. Overall, the functional behavior of the tooltip is preserved, with the primary modification being the styling enhancement to improve the tooltip's display.

Assessment against linked issues

Objective Addressed Explanation
Ensure tooltips do not overlay other elements (3719) The change does not address the issue of overlaying payee names.

Suggested labels

sparkles: Merged

Suggested reviewers

  • youngcw
  • carkom

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 59835a3 and 4592936.

⛔ Files ignored due to path filters (1)
  • upcoming-release-notes/3753.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • packages/desktop-client/src/components/common/Tooltip.tsx (1 hunks)
🔇 Additional comments (1)
packages/desktop-client/src/components/common/Tooltip.tsx (1)

55-55: Additional changes needed in transaction table component.

While constraining the tooltip width is helpful, it doesn't fully address the core issue of payee names overlaying notes in the transaction table. The transaction table component should implement text truncation for payee names.

#!/bin/bash
# Description: Locate the transaction table component to suggest changes
# Expected: Find the component that renders transaction records with payee names

# Search for files that might contain transaction table implementation
echo "Potential transaction table components:"
fd -e tsx -e jsx | rg -i "transaction.*table"

# Search for payee-related rendering code
echo -e "\nPayee rendering implementation:"
rg -A 5 "payee" -g "*.{tsx,jsx}"

Consider implementing these changes in the transaction table component:

  1. Add text overflow handling with ellipsis
  2. Set appropriate width constraints for the payee column
  3. Ensure proper grid/flex layout to prevent overlapping

Would you like me to help locate the specific component and propose the necessary changes?

@@ -52,7 +52,7 @@ export const Tooltip = ({

return (
<View
style={{ minHeight: 'auto', flexShrink: 0 }}
style={{ minHeight: 'auto', flexShrink: 0, maxWidth: '100%' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the code analysis, I can now provide a final response:

Adding maxWidth: '100%' to Tooltip is correct but insufficient to fix the overlaying issue

The payee name truncation is already handled properly by the UnexposedCellContent component which has the correct CSS properties for text truncation:

{
  whiteSpace: 'nowrap',
  overflow: 'hidden',
  textOverflow: 'ellipsis'
}

The issue is likely caused by:

  • The Tooltip's content expanding beyond its container when displayed
  • The cell content not being constrained properly within its container

Recommendations:

  • Keep the maxWidth: '100%' on Tooltip as it helps prevent tooltip overflow
  • Add maxWidth: '100%' to the PayeeCell's container to ensure proper cell content constraints
  • Consider adding minWidth: 0 to the cell to ensure flexbox respects the text truncation
🔗 Analysis chain

LGTM! Verify impact on other tooltip usages.

The addition of maxWidth: '100%' is a good practice to prevent tooltip overflow. However, since this is a common component, we should verify that this change doesn't adversely affect other tooltip instances.


Let me analyze the code to verify the impact of adding maxWidth: '100%' to the Tooltip component.


Let me check the actual cell implementation where the payee name is rendered to understand the truncation behavior.


Let me check the UnexposedCellContent component since it appears to be responsible for rendering the cell content when not being edited.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Find all usages of the Tooltip component to assess impact
# Expected: List of files using Tooltip to manually verify the styling works correctly

# Search for Tooltip imports
echo "Files importing Tooltip:"
rg "import.*Tooltip.*from.*components/common/Tooltip"

# Search for Tooltip usage in JSX/TSX
echo -e "\nTooltip usage in components:"
rg "<Tooltip" -g "*.{jsx,tsx}"

Length of output: 200708


Script:

#!/bin/bash
# Search for Tooltip usage in transaction-related components to understand payee name truncation
echo "Tooltip usage in transaction components:"
rg -A 5 "<Tooltip" packages/desktop-client/src/components/transactions/

# Search for payee name rendering in transaction table
echo -e "\nPayee name rendering implementation:"
rg -A 5 "payee.*name" packages/desktop-client/src/components/transactions/

Length of output: 3119


Script:

#!/bin/bash
# Search for PayeeCell implementation and styling
echo "PayeeCell implementation:"
rg -B 5 -A 15 "function PayeeCell" packages/desktop-client/src/components/transactions/TransactionsTable.jsx

# Search for cell styling related to text overflow
echo -e "\nCell styling for text overflow:"
rg -A 3 "style.*overflow|text-overflow|white-space" packages/desktop-client/src/components/transactions/

Length of output: 1170


Script:

#!/bin/bash
# Search for UnexposedCellContent component implementation
echo "UnexposedCellContent implementation:"
rg -B 5 -A 15 "UnexposedCellContent" packages/desktop-client/src/components/

# Search for any text truncation styles in the components directory
echo -e "\nText truncation styles:"
rg -A 3 "truncate|ellipsis|text-overflow|white-space: nowrap" packages/desktop-client/src/components/

Length of output: 21062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: payees overlaying notes
3 participants