Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move transaction related server handlers from main.ts to server/transactions/app.ts #4221

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 22, 2025

Related to #1113

@actual-github-bot actual-github-bot bot changed the title Move transaction related handlers to server/transactions folder and use the new convention [WIP] Move transaction related handlers to server/transactions folder and use the new convention Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 260bdbe
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6792d17ed9336e0008b7fddc
😎 Deploy Preview https://deploy-preview-4221.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 6.68 MB 0%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/rules/index.ts 🆕 +11.84 kB 0 B → 11.84 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/rules.ts 🔥 -11.84 kB (-100%) 11.84 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/nl.js 58.58 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/en.js 99.31 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/en-GB.js 92.98 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/pt-BR.js 103.38 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/uk.js 111.19 kB 0%
static/js/narrow.js 84.94 kB 0%
static/js/wide.js 102.8 kB 0%
static/js/ReportRouter.js 1.59 MB 0%
static/js/index.js 4.28 MB 0%

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB → 1.33 MB (+49 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/server/rules/index.ts 🆕 +32.43 kB 0 B → 32.43 kB
packages/loot-core/src/server/transactions/transaction-rules.ts 🆕 +31.9 kB 0 B → 31.9 kB
packages/loot-core/src/server/transactions/transfer.ts 🆕 +6.13 kB 0 B → 6.13 kB
packages/loot-core/src/server/transactions/index.ts 🆕 +5.63 kB 0 B → 5.63 kB
packages/loot-core/src/server/transactions/import/ofx2json.ts 🆕 +4.52 kB 0 B → 4.52 kB
packages/loot-core/src/server/transactions/import/parse-file.ts 🆕 +4.22 kB 0 B → 4.22 kB
packages/loot-core/src/server/transactions/import/xmlcamt2json.ts 🆕 +3.76 kB 0 B → 3.76 kB
packages/loot-core/src/server/transactions/export/export-to-csv.ts 🆕 +3.57 kB 0 B → 3.57 kB
packages/loot-core/src/server/transactions/import/qif2json.ts 🆕 +2.63 kB 0 B → 2.63 kB
packages/loot-core/src/server/transactions/app.ts 🆕 +2.24 kB 0 B → 2.24 kB
packages/loot-core/src/server/api.ts 📈 +28 B (+0.13%) 21.04 kB → 21.07 kB
packages/loot-core/src/server/filters/app.ts 📈 +4 B (+0.08%) 4.76 kB → 4.77 kB
packages/loot-core/src/server/accounts/sync.ts 📈 +15 B (+0.06%) 26.19 kB → 26.21 kB
packages/loot-core/src/server/schedules/find-schedules.ts 📈 +4 B (+0.03%) 11.35 kB → 11.36 kB
packages/loot-core/src/server/schedules/app.ts 📉 -5 B (-0.03%) 15.67 kB → 15.67 kB
packages/loot-core/src/shared/schedules.ts 📉 -9 B (-0.07%) 12.53 kB → 12.52 kB
packages/loot-core/src/server/tools/app.ts 📉 -9 B (-0.27%) 3.26 kB → 3.25 kB
packages/loot-core/src/server/rules/app.ts 📉 -12 B (-0.34%) 3.41 kB → 3.4 kB
packages/loot-core/src/server/main.ts 📉 -1.69 kB (-2.43%) 69.5 kB → 67.81 kB
packages/loot-core/src/server/accounts/rules.ts 🔥 -32.43 kB (-100%) 32.43 kB → 0 B
packages/loot-core/src/server/accounts/transaction-rules.ts 🔥 -31.91 kB (-100%) 31.91 kB → 0 B
packages/loot-core/src/server/accounts/transfer.ts 🔥 -6.13 kB (-100%) 6.13 kB → 0 B
packages/loot-core/src/server/accounts/transactions.ts 🔥 -5.63 kB (-100%) 5.63 kB → 0 B
packages/loot-core/src/server/accounts/ofx2json.ts 🔥 -4.52 kB (-100%) 4.52 kB → 0 B
packages/loot-core/src/server/accounts/parse-file.ts 🔥 -4.22 kB (-100%) 4.22 kB → 0 B
packages/loot-core/src/server/accounts/xmlcamt2json.ts 🔥 -3.76 kB (-100%) 3.76 kB → 0 B
packages/loot-core/src/server/accounts/export-to-csv.ts 🔥 -3.56 kB (-100%) 3.56 kB → 0 B
packages/loot-core/src/server/accounts/qif2json.ts 🔥 -2.63 kB (-100%) 2.63 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.33 MB → 1.33 MB (+49 B) +0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@joel-jeremy joel-jeremy changed the title [WIP] Move transaction related handlers to server/transactions folder and use the new convention [WIP] Move transaction related server handlers to server/transactions folder and use the new convention Jan 23, 2025
@joel-jeremy joel-jeremy force-pushed the server-transaction-handlers branch from 1761118 to 1541fbd Compare January 23, 2025 16:58
@@ -108,56 +106,6 @@ handlers['redo'] = mutator(function () {
return redo();
});

handlers['transactions-batch-update'] = mutator(async function ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been moved to server/transactions/app.ts

@joel-jeremy joel-jeremy changed the title [WIP] Move transaction related server handlers to server/transactions folder and use the new convention [WIP] Move transaction related server handlers from main.ts to server/transactions/app.ts folder and use the new convention Jan 23, 2025
@joel-jeremy joel-jeremy changed the title [WIP] Move transaction related server handlers from main.ts to server/transactions/app.ts folder and use the new convention [WIP] Move transaction related server handlers from main.ts to server/transactions/app.ts Jan 23, 2025
@joel-jeremy joel-jeremy force-pushed the server-transaction-handlers branch from 319ed57 to 941adf3 Compare January 23, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant