Automatically close feature requests as "not planned" instead of "completed" #4231
Conversation
Close issues as "not planned" for clarity
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
e13h
changed the title
WalkthroughThe pull request introduces a modification to the GitHub Actions workflow file Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/issues-close-feature-requests.yml (1)
Line range hint
19-31: Consider updating the automated comment to reflect the closure reason.The comment explains that issues are automatically closed but doesn't explicitly mention they're marked as "not planned". Consider updating the message to be more transparent about the closure status.
Here's a suggested update to the comment:
:sparkles: Thanks for sharing your idea! :sparkles: This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesn't mean we don't accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution). + Note: Feature requests are marked as "not planned" when closed. This helps distinguish them from completed features while keeping them visible in the enhancement backlog for future consideration. + The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+ Don't forget to upvote the top comment with 👍! <!-- feature-auto-close-comment -->
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4231.mdis excluded by!**/*.md
📒 Files selected for processing (1)
.github/workflows/issues-close-feature-requests.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Visual regression
- GitHub Check: Functional
🔇 Additional comments (1)
.github/workflows/issues-close-feature-requests.yml (1)
35-35: LGTM! Verify the command syntax.The change correctly implements closing issues with "not_planned" reason instead of the default "completed".
Let's verify the command syntax:
I understand that the project uses lodash issue management and immediately closes feature requests. It's a little odd though that the GitHub issues are closed as "completed" by the bot when they pretty clearly are not complete. Since GitHub supports closing an issue as "not planned", can we do that instead?