Handle duplicate categories/groups in nYNAB importer. #4293
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
youngcw
changed the title
WalkthroughThe changes introduce a retry mechanism in the Assessment against linked issues
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/loot-core/src/server/importers/ynab5.ts (1)
115-135: Consider adding logging for renamed categories.Adding debug logs when categories are renamed would help with troubleshooting import issues.
while (run) { try { const id = await actual.createCategory({ name: cat.name, group_id: groupId, }); entityIdMap.set(cat.id, id); run = false; } catch (e) { + console.debug(`Retrying category creation with new name. Original: ${origName}, Attempt: ${count}`); cat.name = origName + '-' + count.toString(); count += 1; if (count >= 100) {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4293.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/loot-core/src/server/importers/ynab5.ts(1 hunks)
youngcw
changed the title
| @@ -79,13 +79,30 @@ async function importCategories( | |||
| if ( | |||
| !equalsIgnoreCase(group.name, 'Internal Master Category') && | |||
| !equalsIgnoreCase(group.name, 'Credit Card Payments') && | |||
| !equalsIgnoreCase(group.name, 'Hidden Categories') && | |||
There was a problem hiding this comment.
This group will be empty after the import, so just ignore it.
Handles the condition where nYNAB imports have duplicate categories or groups.
fixes #3069