chore: remove unsed vars & cleanups #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MatissJanis
commented
Jan 7, 2023
| let [arg1] = valArray(state, args, ['string']); | ||
| return typed(`LOWER(${arg1})`, 'string'); | ||
| } | ||
|
|
||
| // integer/float functions | ||
| case '$neg': { | ||
| validateArgLength(args, 1); | ||
| // eslint-disable-next-line no-unused-vars | ||
| let [arg1] = valArray(state, args, ['float']); | ||
| valArray(state, args, ['float']); |
There was a problem hiding this comment.
Throws an exception if the vars are invalid, so we can't remove it.
| // }); | ||
| // }); | ||
| // }); | ||
| test('querying transactions works', async () => { |
There was a problem hiding this comment.
Only uncommenting these tests. No changes in them.
| @@ -183,7 +183,7 @@ export default class Spreadsheet { | |||
| this.events.emit('change', { names: this.computeQueue }); | |||
|
|
|||
| // Cache the updated cells | |||
| if (this.saveCache) { | |||
| if (typeof this.saveCache === 'function') { | |||
There was a problem hiding this comment.
Making the tests pass.
|
Performed the following steps and verified the test cases pass
Performed the following steps to verify the code change to
Please let me know if there are additional steps/actions I can take to assist in resolving this issue. |
|
Thanks for reviewing, @TechwizEE! |
eshaffer321
pushed a commit
to eshaffer321/actual-fork
that referenced
this pull request
Jan 19, 2023
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a couple more unused variables + a tiny improvement in the compiler to make some more tests pass.