-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reworking template docs #606
Open
youngcw
wants to merge
12
commits into
master
Choose a base branch
from
youngcw/rework-template-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+349
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
start reworking template docs
[WIP] start reworking template docs
Jan 8, 2025
✅ Deploy Preview for actualbudget-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
actual-github-bot
bot
added
🔍 Ready for review
Someone needs to look into this.
and removed
🚧 WIP
labels
Jan 8, 2025
matt-fidd
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is BRILLIANT, a massive improvement to what was there before.
A couple of very tiny nits that jumped out at me when reading but feel free to ignore them
actual-github-bot
bot
added
✅ Approved
Used in conjunction with Merge at Release. This means that the PR has been approved but not merged.
and removed
🔍 Ready for review
Someone needs to look into this.
labels
Jan 12, 2025
actual-github-bot
bot
added
the
✅ Approved
Used in conjunction with Merge at Release. This means that the PR has been approved but not merged.
label
Jan 12, 2025
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
actual-github-bot
bot
added
🔍 Ready for review
Someone needs to look into this.
and removed
✅ Approved
Used in conjunction with Merge at Release. This means that the PR has been approved but not merged.
labels
Jan 12, 2025
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of getting the existing template setup ready to mainline. We can consider making each template type its own file if this feels too long.