Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the regularly appearing notification 'Background Items Added' (introduced in macOS 13 Ventura) #101

Merged
merged 4 commits into from
Mar 12, 2023

Conversation

clemenstyp
Copy link
Contributor

The proposed change modifies the "create_daemon" function, so that the daemon file is only overwritten if it does not yet exist or the contents have changed.

This fixes the frequently appearing notification 'Background Items Added' (introduced in macOS 13 Ventura)

This notification occurs, for instance, when the app is restarted or when "battery maintain 80" is executed.

only overwrite the daemon file if it doesn't exist yet or the content changes.
This fixes the often popping up notification 'Background Items Added' (introduced in macOS 13 Ventura)
@clemenstyp clemenstyp closed this Mar 8, 2023
@clemenstyp clemenstyp reopened this Mar 8, 2023
@clemenstyp

This comment was marked as resolved.

@clemenstyp clemenstyp closed this Mar 8, 2023
only disable (instead of remove) daemon on "battery maintain stop"
@clemenstyp clemenstyp reopened this Mar 9, 2023
@clemenstyp
Copy link
Contributor Author

clemenstyp commented Mar 9, 2023

It works correctly now. I added a function disable_daemon which does not trigger the notification.

The "battery maintain stop" function triggered the remove_daemon function. If the (launchd) daemon did not exist, create_daemon recreated it and the notification appeared.
Now create_daemon only adds a new launchd daemon if it does not already exist or has changed, and then enables the daemon. disable_daemon then disables only that existing daemon.

@actuallymentor
Copy link
Owner

This is a really nice addition!

Could you please increment the CLI version number at the top of the file with one x.x.1 increment?

@actuallymentor actuallymentor merged commit 5f00cb5 into actuallymentor:main Mar 12, 2023
@actuallymentor
Copy link
Owner

Thanks for the addition @clemenstyp! The notification was starting to bother me too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants