-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future of action - consider archiving #104
Comments
@Ale0x78 , Hey, since you have commented in my other semi-public repository, which indicates that you are widely open to open-source collaborations, do you have your opinion on this? |
So I've been using this action for a while now, and it was because I couldn't figure out how to make "git push" work by itself, and I didn't bother to look at your code to understand why yours worked. I just figured it out after reading your source (it needed to be HEAD:master not just master), but I have a feeling a lot of people run into the same problem I have. I think it makes sense to archive it, but I would update the readme with a pretty basic step-by-step of how to use checkout and basic shell commands instead. So when people come looking for a solution, they will still find one. |
I've used this repo everywhere. The reason is that I can simply pass another "github_token" so that I can trigger other github actions workflows from a workflow inside. |
We use it to push commits to another github repo. Repo 1 gets commits. It then merge commits those changes into Repo 2. |
* chore: ignore files created by awesome_bot * feat: auto-update README.md when PRs are created * feat: use danger to post awesome_bot results on PRs * chore: wut * Update pull_requests.yml * chore: fake-test * adjust branch used by github-push-action * chore: ensure checkout uses the branch * chore: update README.md * chore: modify dangerfile and workflow ordering * remove fake addition to videos.yaml * chore: update README.md * chore: rename pull_requests.yml * temp: always display awesomeBot results * Revert "temp: always display awesomeBot results" This reverts commit acaef1f. * chore(deps): install danger as devDep * feat: cache node_modules and readme * Update pull_requests.yml * chore: remove ad-m/github-push-action see ad-m/github-push-action#104 * tmp: PR-demo * Rebuild * Revert "tmp: PR-demo" This reverts commit 8bed132. * Rebuild * fix: no need to push readme update * fix: no need to push readme update readme is updated during 'Rebuild' commit from data.yml * chore: run danger via npm script instead of npx * feat: remove replace circleci cron with github action this github action should open a PR removing broken links automatically Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Using it to push to another repo than the one triggering the action… also, didn't even consider Seeing you can pass a token there, I guess I should check if it does what we need, though. |
I am afraid that this project has little usefulness at the moment, thanks to the development of "actions/checkout", which simplifies the use of tokens. Additionally, getting to know Git better, which indicates that you don't have to use "base64" and your own headers to pass the token further simplifies.
This action is a simple git wrapper that adds an extra (redundant) layer of abstraction. The current open issues are mostly oriented around crossing this abstract layer (with the extreme approach of adding any parameter - see #101) or not understanding git (#99).
I am thinking of archiving this action. Could someone please indicate which operations are not easier for him or at least not possible to do with "actions/checkout" (see example "Push a commit using the built-in token") than with this action?
The text was updated successfully, but these errors were encountered: