This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Add A4G prebid adapter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kononenko-a-m
force-pushed
the
feature/INC-9
branch
from
8a1ad42 to
51944c9
Compare
Entea
approved these changes
May 24, 2017
src/adapters/a4g.js
Outdated
| } | ||
|
|
||
| return { | ||
| callBids({ params }) { |
There was a problem hiding this comment.
Excuse me for a js noob question:
I got used to see object literals that look like {methodName: function() {} } but this one look a bit different, wonder how it works
There was a problem hiding this comment.
that's es6 syntax for defining methods, works in the same way but adds some syntax sugar, so expression looks less noise. if you are interested in understanding how it gonna be transpiled, you might find useful this tool:
https://babeljs.io/repl/#?babili=false&evaluate=true&lineWrap=false&presets=es2015%2Ces2016%2Creact%2Cstage-2&targets=&browsers=&builtIns=false&debug=false&code=var%20obj%20%3D%20%7B%0A%20%20method()%20%7B%20%0A%20%20%20%20return%201%3B%0A%20%20%7D%0A%7D
kononenko-a-m
force-pushed
the
feature/INC-9
branch
2 times, most recently
from
1adedd5 to
7dc5e56
Compare
kononenko-a-m
force-pushed
the
feature/INC-9
branch
from
7dc5e56 to
080f936
Compare
rathko
approved these changes
Jun 6, 2017
sjukeshov
approved these changes
Aug 9, 2017
kononenko-a-m
pushed a commit
that referenced
this pull request
Aug 23, 2017
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding multi imp ORTB support * replacing existing lite adapter code * interim commit * pulseLite - native tests * pulseLite - native tests * registering new adapter name via alias
kononenko-a-m
pushed a commit
that referenced
this pull request
Aug 23, 2017
…id#1383) * ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding createNew method on the adapter for aliasing
adilets
pushed a commit
that referenced
this pull request
Oct 31, 2017
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2) * ET-1850: Fixing prebid#866 * Minor fix * Refactoring current functionality to work with bidderFactory (for 1.0 migration) * More tests. * Adding support for "app" requests. * fixing eslint issues * adding adapter documentation * minor doc update * removing usage of reserved keyword 'native'
adilets
pushed a commit
that referenced
this pull request
Oct 31, 2017
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (prebid#2) * ET-1850: Fixing prebid#866 * Minor fix * Enabling User sync pixel * minor fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.