Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cobertura outputs #29

Merged
merged 49 commits into from
Feb 5, 2024
Merged

Support cobertura outputs #29

merged 49 commits into from
Feb 5, 2024

Conversation

islyn
Copy link
Contributor

@islyn islyn commented Sep 5, 2023

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #553498: update jest coverage report github action to support cobertura outputs.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

Coverage Report

  • Status: ✅ Passed
Click to view remaining coverage report
Status File Stmts Branch Funcs Lines
✨ 🆕 com.tubitv.ads.manager.dependency.grpc.VideoTranscodeClient 0 0 0 0
✨ 🆕 com.tubitv.ads.manager.graphqlapi.routes.AdserverCreativeApiRoutes 0 0 0 0
✨ 🆕 com.tubitv.ads.manager.init.IngressRouteModule 0 0 0 0
✨ 🆕 com.tubitv.ads.manager.neo.creatives.routes.CreativeRoutes 0 0 0 0
✨ 🆕 com.tubitv.adserver.jobs.DateArgExtractor 0 0 0 0
Total 62.15%
Change from base: 0%
Covered Lines: 9537
Total Lines: 15344

@islyn islyn added the invalid This doesn't seem right label Sep 5, 2023
@islyn islyn changed the title Support cobertura outputs [Draft] Support cobertura outputs Sep 5, 2023
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 94b91db to bbb2bd8 Compare September 6, 2023 09:14
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from fbf1dda to 65bc475 Compare September 6, 2023 13:27
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 635c036 to 16af119 Compare September 12, 2023 14:11
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 7dfb584 to b8a562e Compare January 31, 2024 05:15
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 9dab0d4 to 1d2b6d9 Compare January 31, 2024 06:45
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 5641363 to df5e17d Compare February 1, 2024 15:35
@adRise adRise deleted a comment from github-actions bot Feb 1, 2024
@adRise adRise deleted a comment from github-actions bot Feb 1, 2024
arunshan
arunshan approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@arunshan arunshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@islyn Will this affect www workflow as well? If not, then lets merge it after fixing the failed tests.

Thank you for working on this.

@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 68842a0 to 5f77089 Compare February 5, 2024 06:22
@islyn islyn added the skip-new-file-full-coverage Skip full coverage check for new files label Feb 5, 2024
@islyn islyn force-pushed the liuying/sc-553498/feature/support-cobertura-outputs branch from 804c3c5 to 7a7e921 Compare February 5, 2024 07:26
@islyn islyn added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit e13d763 Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshan arunshan arunshan approved these changes

Assignees
No one assigned
Labels
skip-new-file-full-coverage Skip full coverage check for new files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islyn @arunshan