Skip to content

Changes for version 1.23.0 / ada 3.2.4 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Changes for version 1.23.0 / ada 3.2.4 #110

merged 2 commits into from
Apr 28, 2025

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Apr 28, 2025

This PR upgrades to ada 3.2.4.

anonrig
anonrig approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have ada_include_url_pattern flag defined in this project? If not we should set it to 0 to reduce the binary size.

@bbayles
Copy link
Collaborator Author

bbayles commented Apr 28, 2025

OK, I added eeb39f1 to disable

@bbayles bbayles merged commit 0097d63 into main Apr 28, 2025
9 checks passed
@bbayles bbayles deleted the version-1.23.0a branch April 28, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbayles @anonrig