fixes overlap and add debug mode test #1053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Jan 3, 2026
| // This triggers assertion failure in debug mode for url_aggregator | ||
| // because get_pathname() returns a view into the buffer, and set_hostname() | ||
| // modifies it. | ||
| url->set_hostname(url->get_pathname()); |
Member
There was a problem hiding this comment.
You are acquiring a view into the URL, and then, at the same time, trying to modify the URL. You need to make a copy first.
Member
There was a problem hiding this comment.
Agreed that this isn't the correct solution. We already have debug assertions that validates this behavior if i remember correctly it is ADA_DEVELOPMENT_CHECKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.