Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -Wunreachable-code-break warning #464

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

ckerr
Copy link
Contributor

@ckerr ckerr commented Jul 19, 2023

Fix a small -Wunreachable-code-break warning.

I found this a few steps downstream in Electron while working on Electron's Node.js roll, since Electron builds node with -Werror,-Wunreachable-code-break and Node.js uses ada 😸

@anonrig
Copy link
Member

anonrig commented Jul 19, 2023

Thanks for the PR @ckerr. Can you also open a PR to https://github.com/ada-url/idna for this fix?

@lemire lemire merged commit 391940b into ada-url:main Jul 19, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull request Sep 20, 2023
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants