fix(url): handle :port values in host setter#963
Merged
anonrig merged 1 commit intoada-url:mainfrom Jun 29, 2025
Merged
Conversation
a094ace to
c8a713d
Compare
anonrig
reviewed
Jun 29, 2025
| return false; | ||
| } else if (has_dash_dot()) { | ||
| add_authority_slashes_if_needed(); | ||
| // Should remove dash_dot from pathname |
lemire
approved these changes
Jun 29, 2025
anonrig
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation incorrectly allows values like ":80" (empty host with port), resulting in
foo://:80/to, while the spec requires failure if the host is missing. This update aligns behavior with the spec.Refs: https://url.spec.whatwg.org/#host-state
WPT tests for this case will be added in a follow-up PR.