Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the command should run #25

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Check if the command should run #25

merged 1 commit into from
Jul 7, 2018

Conversation

predragnikolic
Copy link
Contributor

@predragnikolic predragnikolic commented Jul 3, 2018

closes #24

It will run the command only if the current cursor position scope contains embedding.php, which is everywhere in a php file. :)

As far as I understand (I never heard of .ctp :D) to have syntax higlighting for .ctp you need to set the syntax to PHP. And by doing so, it shouldn't matter if the file extension ends with .ctp as long as the scope at the cursor contains embedding.php, the command will fire.

If you have any suggestion, question or concern, I am here :)

@adael adael merged commit 3f628c3 into adael:master Jul 7, 2018
@adael
Copy link
Owner

adael commented Jul 7, 2018

Looks pretty good, thank you very much.
I'm currently at the beach without my laptop. I'll check this next monday, or so, and tag a new version.

@predragnikolic predragnikolic deleted the enable-command-for-php-scope-only branch July 7, 2018 17:41
@predragnikolic
Copy link
Contributor Author

No problemoo :)
Have a nice day.

@predragnikolic predragnikolic restored the enable-command-for-php-scope-only branch July 7, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run the command if it is not a php file
2 participants