Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MonoOLED i2c constructor to match var def order #290

Merged
merged 1 commit into from
May 17, 2020

Conversation

nsasch
Copy link
Contributor

@nsasch nsasch commented May 17, 2020

This updates the initialization of variables in the I2C Adafruit_MonoOLED constructor. The call signature and variable definitions are unchanged. This fixes a reorder compiler warning due to member initialization not matching member declaration. This becomes a compiler error with the standard ESP32 platform.txt with warning level "All".

The mock_ili9341 example compiles with no new warnings with compiler.warning_level=all in the latest Arduino IDE. This was tested for Adafruit Circuit Playground, ESP32, and Arduino Due.

Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much :)

@ladyada ladyada merged commit 0393044 into adafruit:master May 17, 2020
@ladyada
Copy link
Member

ladyada commented May 17, 2020

i should figure out how to turn on warning_level=all in the arduino cli so CI can catch it, do you know how by chance?

@nsasch
Copy link
Contributor Author

nsasch commented May 17, 2020

I'm not sure off-hand. It might require a change in adafruit/ci-arduino. I'll look into it today, and either make another PR or comment here with what I find. I'm sure it's one line of code... just need to find which line.

@ladyada
Copy link
Member

ladyada commented May 17, 2020

yeah ideally we update ci-arduino and then all 250+ arduino libraries will get the new check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants