Update for SPI delay (ESP32) #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 1ms delay for spi, because V3 board from Aliexpress doesn't read cards properly without it
Flick3rF3r
changed the title
Flick3rF3r
changed the title
|
Can we re-run this, so we can figure out why the buil failed? |
|
I had another instance on a different model board of dropped ACK frames that wasn't solved by any amount of delay, either micros or millis. See info in #117 but basically changing the SPI speed helped. It might be a better solution, as it seems to apply to more instances. I also suggested a few changes to make it so we could pass in either a custom SPI speed or just a custom SPI device to keep everything flexible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 1ms delay for SPI too, because my V3 counterpart board from Aliexpress doesn't read cards properly without it (seen other people complain about it too) I'm using it with ESP32, works fine with Arduino for some reason. There are probably better ways to achieve the same result so correcting me is welcome ;)