Move Mode consts into an enum like class. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
reviewed
Feb 5, 2019
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Code looks good. I don't have the hardware to test it on though.
makermelissa
approved these changes
Feb 6, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 6, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#25 from caternuson/iss21_consts > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#24 from caternuson/iss23_gain Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#13 from kattni/add-demos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #21.
NOTE Continuous doesn't actually work right now. Probably need to change the wait-for-conversion-complete behavior. Suggest covering that in a separate issue.