Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeHints to adafruit_io.py #98

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Add TypeHints to adafruit_io.py #98

merged 5 commits into from
Jul 31, 2023

Conversation

ForgottenProgramme
Copy link
Contributor

Resolves #79

@tekktrik
Copy link
Member

Looks like this is failing the CI. You can use pre-commit to help fix the issues it's having. You can find information on how to install and use pre-commit here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

tekktrik
tekktrik previously requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above :)

FoamyGuy
FoamyGuy requested changes May 30, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit that fixed up the actions issues and merged the latest from main.

I've had a look over this and found a few things I think we'll want to have changed.

adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
adafruit_io/adafruit_io.py Show resolved Hide resolved
adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
adafruit_io/adafruit_io.py Outdated Show resolved Hide resolved
FoamyGuy
FoamyGuy approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commit addresses all requested changes.

The current version is looking good to me.

Thanks again for making this contribution!

@FoamyGuy FoamyGuy requested a review from tekktrik June 5, 2023 20:44
@FoamyGuy FoamyGuy dismissed tekktrik’s stale review July 31, 2023 15:47

Changes were made with newer commits.

@FoamyGuy
Copy link
Contributor

I had another look over this one. Going to merge it. Any further changes or adjustments can come in a followup PR / issue.

@FoamyGuy FoamyGuy merged commit 0772f3b into adafruit:main Jul 31, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 1, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@012b13e)
5b42218 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.21 from 3.3.20:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#37 from jposada202020/updating_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.7.2 from 5.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#98 from ForgottenProgramme/mahe-typehint

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.2.0 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#63 from michalpokusa/external-routes-websockets-sse

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoKey to 1.1.0 from 1.0.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoKey#11 from EAGrahamJr/all-the-buttons

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.17 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGBLED#23 from BiffoBear/Add_typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 2.2.16 from 2.2.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#50 from samatjain/type-annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@tekktrik tekktrik Awaiting requested review from tekktrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants
@ForgottenProgramme @tekktrik @FoamyGuy