Handle entry properly for subclasses of Advertisement #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.0.1 from 8.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#125 from dhalbert/adv-entry-handling Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.5.3 from 1.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#32 from zsimpso/fix-31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
entryis supplied to anAdvertisementconstructor, its values would override any default values, so only use the values passed in via theentry.@kschmelzer Could you test to see if this fixes your problem?
Fixes #124.