doc and cleanup pass

[dhalbert]

I made a pass over all the files to do a more thorough code review, made some changes, and updated some doc. In general:

-- Use of kwargs was mostly dropped in favor of explicit arg names.
-- In a few places, the fact that an object was from _bleio was made more explicit.
-- Some pylint overrides were removed by renaming variables, etc.
-- A couple of pylint warnings were dealt with.
-- _bleio.Attribute and _bleio.Characteristic CONSTANT values were duplicated in the library, so that user code and library code does not need to refer to these directly.
-- 8, 16, and 32 bit signed and unsigned characteristic classes were created.

• Fixed an apparent bug in time_struct stuff, caught by @jerryneedell.

Tested ble_uart_echo_test.py andble_detailed_scan.py.
Tested ble_demo_central.py and ble_demo_periph.py working together on a pair of CPB's.

There is one minor corresponding fix to circuitpython which I'll submit a PR for shortly.

[tannewt]

A few comments from the first couple files. Will finish later.

[jerryneedell]

Don’t these references to “core” have to be fixed?

Adafruit_CircuitPython_BLE/adafruit_ble/services/standard/standard.py

Line 32 in dcf76c7

from ..core import Service

[dhalbert]

@jerryneedell Yes, thanks, that code wasn't used, so it didn't get vetted.

[jerryneedell]

hmm -- tried simpletest

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 5.0.0-alpha.5-80-g166518fc9 on 2019-11-13; Adafruit Feather nRF52840 Express with nRF52840
>>> import ble_simpletest
scanning
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "ble_simpletest.py", line 10, in <module>
  File "adafruit_ble/__init__.py", line 198, in start_scan
TypeError: can't convert NoneType to float
>>> 

[dhalbert]

@jerryneedell This is fixed by adafruit/circuitpython#2287, so you need a newer CPy.

[jerryneedell]

Ah -- so it is!! Sorry - I missed that commit to CP. works fine

[jerryneedell]

FYI -- each of these needs one more "." ...characteristics

[jerryneedell]

Still returns all 0's ,but with that change, it does not throw any errors ;-)

[dhalbert]

Oops, I will push another change, but what returns all 0's?

[jerryneedell]

I've been running this -- modified from your old version

"""CTS demo
"""

import board
import displayio
import terminalio
import time

import adafruit_displayio_ssd1306
from adafruit_display_text import label
from adafruit_ble import BLERadio
from adafruit_ble.advertising.standard import ProvideServicesAdvertisement
from adafruit_ble.services.standard.standard import CurrentTimeService

ble = BLERadio()
cts = CurrentTimeService()
advertisement = ProvideServicesAdvertisement(cts)



displayio.release_displays()

i2c = board.I2C()
display_bus = displayio.I2CDisplay(i2c, device_address=0x3c)
display = adafruit_displayio_ssd1306.SSD1306(display_bus, width=128, height=32)

FONT = terminalio.FONT
WHITE = 0xffffff
CONNECTING = "Connecting..."
text = CONNECTING

text_area = label.Label(FONT, max_glyphs=50, text=text, color=WHITE)

text_area.x = 0
text_area.y = 10


display.show(text_area)

while True:
    text_area.text = CONNECTING
    ble.start_advertising(advertisement)
    while not ble.connected:
        pass

    while ble.connected:
        print(cts.struct_time)
        year, month, day, hour, minute, second, _, _, _ = cts.current_time
        text_area.text = '{}-{}-{} {:02}:{:02}:{:02}'.format(year, month, day, hour, minute, second)
        time.sleep(5)

I don't get the pairing option on Settings on my iPhone, but if I connect via the BLE Conect App it connects and but the time struct is all 0's

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 5.0.0-alpha.5-84-g4c55431bb on 2019-11-14; Adafruit Feather nRF52840 Express with nRF52840
>>> import cts
struct_time(tm_year=0, tm_mon=0, tm_mday=0, tm_hour=0, tm_min=0, tm_sec=0, tm_wday=-1, tm_yday=-1, tm_isdst=-1)

[jerryneedell]

This does not have to be resolved for this PR -- no need to hold things up.

[jerryneedell]

Tested central/periph demo on CPBs and uart_echo_test,ble_simpletest and ble_detailed_scan on feather_nrf52840. Latest fixes to standard.py fix the errors I was seeing - still experimenting with CTS but not working yet.

[tannewt]

Looks good! Thanks for the polish.