Skip to content

start_scan() advertisement_types needs to default to (Advertisement,) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2020
Merged

start_scan() advertisement_types needs to default to (Advertisement,) #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions adafruit_ble/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,9 @@ def start_scan(
If none are given then `Advertisement` objects will be returned.
:rtype: iterable
"""
prefixes = b""
if advertisement_types:
prefixes = b"".join(adv.prefix for adv in advertisement_types)
if not advertisement_types:
advertisement_types = (Advertisement,)
prefixes = b"".join(adv.prefix for adv in advertisement_types)
for entry in self._adapter.start_scan(
prefixes=prefixes,
buffer_size=buffer_size,
Expand Down