Skip to content

packet_size -> incoming_packet_length #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2021
Merged

packet_size -> incoming_packet_length #2

merged 6 commits into from
Apr 8, 2021
+3 −7

Conversation

@tannewt
Copy link
Member

@tannewt tannewt commented Apr 8, 2021

@tannewt tannewt requested a review from dhalbert April 8, 2021 20:06
dhalbert
dhalbert approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dhalbert
dhalbert requested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to try to remove superfluous pylint disable.

tannewt and others added 2 commits April 8, 2021 13:22
@tannewt @dhalbert
Remove disable
a3ae263 
Co-authored-by: Dan Halbert <halbert@adafruit.com>
@dhalbert
cleanup
38653bd
@tannewt tannewt requested a review from dhalbert April 8, 2021 20:59
@dhalbert dhalbert merged commit fe449e0 into main Apr 8, 2021
@dhalbert dhalbert deleted the tannewt-patch-1 branch April 8, 2021 22:24
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 10, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
74b5ec5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#2 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#1 from hugodahl/feature/Fix-GitHub-action-issues
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert Awaiting requested review from dhalbert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tannewt @dhalbert