switch from custom short int parser to builtin #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Aug 8, 2022
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
This looks correct, and it looks like the original code was off by 1 for negative temperatures as well, and this is not. Thanks!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 8, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.3.0 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#13 from adafruit/MCP4728A4_update > Added Black formatting badge > Changed .env to .venv in README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC to 1.0.9 from 1.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_LYWSD03MMC#5 from NanoExplorer/struct_features > Changed .env to .venv in README.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct library can do the short int parsing for us so we don't have to have as many bitwise operations