Add initial functionality for I2C and SPI. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caternuson
commented
Nov 1, 2018
caternuson
commented
- basic readings: pressure, temperature, altitude
- over sampling individually settable for pressure and temperature
- IIR filter coefficient
tannewt
requested changes
Nov 4, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One thing but good otherwise.
adafruit_bmp3xx.py
Outdated
| raise RuntimeError('Failed to find BMP3XX! Chip ID 0x%x' % chip_id) | ||
| self._read_coefficients() | ||
| self.reset() | ||
| self.sea_level_pressure = 1013.25 # hPa @ MSL |
Member
There was a problem hiding this comment.
Add a """comment""" after this so sea_level_pressure is shown in RTD.
Member
|
i tested this code, seems to work fine so after the minor update, we can merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.