Possible fix for #11 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would like someone to review, didn't setup hardware tests yet. Will do so when I have more time. Thanks for the Hacktoberfest tag!
caternuson
requested changes
Oct 9, 2018
adafruit_bno055.py
Outdated
| accel = (calibration_data >> 2) & 0x03 | ||
| mag = calibration_data & 0x03 | ||
| return sys, gyro, accel, mag | ||
|
|
There was a problem hiding this comment.
Being able to get the individual status's might be useful. Change this to a property called calibration_status, still returning the same tuple.
| if sys < 3 or gyro < 3 or accel < 3 or mag < 3: | ||
| return False | ||
| return True | ||
|
|
There was a problem hiding this comment.
Change name to simply calibrated. And a python-y way to do the check and return is:
return sys == gyro == accel == mag == 0x03Also - the doc strings for properties should read like a variable, not a function. So instead of describing what it does ("Returns..."), describe what it is ("The status of...").
|
Thank you for the review. I've made the requested changes. This is helping me understand Python decorators better too. 👍 |
caternuson
requested changes
Oct 9, 2018
caternuson
approved these changes
Oct 9, 2018
|
Thanks for the update! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 11, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.0.4 from 3.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#15 from davidskeck/patch-1 > ignore the board module imports in .pylintrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like someone to review, didn't setup hardware tests yet. Will do so when I have more time. Thanks for the Hacktoberfest tag!