-
Couldn't load subscription status.
- Fork 6
Ran black, updated to pylint 2.x #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tannewt Can you comment on the change discussed above please? You were involved in resolving the other instance of this. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all good to me. I thought the output of dir() is a sequence already but this will ensure they are lists still like before.
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#21 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#20 from sommersoft/patch_coc_2 Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.4.0 from 0.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#18 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update example file pylint > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#17 from sommersoft/patch_coc_2 Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.1.0 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#73 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#71 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.1.0 from 1.0.3: > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#9 from sommersoft/patch_coc > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#8 from adafruit/pylint_update Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#17 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update example file pylint > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#16 from sommersoft/patch_coc_2 Updating https://github.com/adafruit/Adafruit_CircuitPython_RockBlock to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_RockBlock#6 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_RockBlock#5 from sommersoft/patch_coc_2 Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.0 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#17 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#16 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.0 from 1.0.2: > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#6 from adafruit/pylint_update > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#7 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.2.0 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#15 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#14 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#10 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#8 from RichardA1/master > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#9 from sommersoft/patch_coc > update pylintrc for black > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.9.0 from 0.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#6 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#5 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#11 from adafruit/pylint-update > update code of coduct: discord moderation contact section > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#10 from sommersoft/patch_coc > update pylintrc for black > build.yml: move pylint, black, and Sphinx installs to each repo; add description to 'actions-ci/install.sh' Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.3.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#18 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update example file pylint > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#17 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 1.3.0 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#12 from adafruit/pylint-update > update build.yml to pip install pylint black sphinx > update pylintrc for black > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#11 from sommersoft/patch_coc Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 1.1.0 from 1.0.1: > update example file pylint > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#15 from sommersoft/patch_coc > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#14 from adafruit/pylint-update > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#12 from dglaude/patch-1
I changed this:
pins = [p for p in dir(board)]to this:
pins = list(dir(board))in these lines of these files:
let me know if that was the correct way to do that or if there is a better way. I seem to recall us coming across something similar in another PR, I just forget how it was resolved.