Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap matching #96

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Tap matching #96

merged 6 commits into from
Jul 17, 2020

Conversation

evaherrada
Copy link
Collaborator

Fixes #77

@evaherrada evaherrada requested a review from a team July 17, 2020 17:08
kattni
kattni suggested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dherrada Thank you for looking into this. Please look into handling board detection differently.

adafruit_circuitplayground/circuit_playground_base.py Outdated Show resolved Hide resolved
@kattni kattni changed the base branch from master to main July 17, 2020 17:39
@evaherrada evaherrada requested a review from kattni July 17, 2020 19:23
kattni
kattni suggested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with CPB, works successfully. Please update comment below.

adafruit_circuitplayground/circuit_playground_base.py Outdated Show resolved Hide resolved
@evaherrada evaherrada requested a review from kattni July 17, 2020 20:24
@kattni kattni merged commit a0692df into main Jul 17, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 23, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@0b83e6e)
29fd750 
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.2.1 from 4.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#100 from adafruit/REUSE
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#96 from adafruit/tap-matching

Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.7.1 from 2.7.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_EPD#44 from adafruit/REUSE
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#19 from adafruit/REUSE
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#18 from peterhinch/patch-1
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.5 from 2.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#28 from adafruit/REUSE
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#26 from chrisbailey4/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 4.1.0 from 4.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#55 from flavio-fernandes/socket_read_fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#17 from adafruit/REUSE
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 2.2.0 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#36 from imliubo/master
@evaherrada evaherrada deleted the tap-matching branch June 21, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tap detection on Circuit Playground Bluefruit hypersensitive
2 participants
@evaherrada @kattni