Fixed off by one error with horizontal and vertical lines #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works great, now the coordinate points act as expected. |
Collaborator
Author
|
I just tested that this does not affect sparkline negatively because it is rarely using horizontal and vertical lines and diagonal lines were working as expected.. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 6, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.0.0 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#23 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#22 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became apparent when using the polygon function. Due to the way Range works, it was chopping off the last values.