Fixed wrapping function when text length = maxchars #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix, I will test this out tonight. |
|
I think we still have some kind of issue here. This line no longer throws an exception but it's also dropping the entire first word: |
FoamyGuy
reviewed
Dec 18, 2020
|
Ok, I made a small adjustment. It seems the Hello World was more of an edge case and I adjusted for that. |
FoamyGuy
approved these changes
Dec 22, 2020
|
Thanks @FoamyGuy |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 22, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#15 from bettse/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.10.1 from 2.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#105 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.1 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#56 from askpatrickw/bytesarray-split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104. This now works on short text when the max_chars is equal to the text words.